Remove semicolon from text/plain content type in example Swagger specs#2022
Merged
Ruwann merged 1 commit intospec-first:mainfrom Jun 9, 2025
Merged
Conversation
chrisinmtown
force-pushed
the
examples-swagger-semicolon
branch
from
8034736 to
e9337d7
Compare
chrisinmtown
changed the title
chrisinmtown
force-pushed
the
examples-swagger-semicolon
branch
from
e9337d7 to
03ebdb5
Compare
Contributor
Author
|
Happy new year to the Connexion community. I think this just might be the smallest PR I have ever created ;) Please review when you can, thanks. |
FelixSchwarz
approved these changes
Jan 21, 2025
Contributor
FelixSchwarz
left a comment
FelixSchwarz
left a comment
There was a problem hiding this comment.
Well, that looks obviously correct :-)
Contributor
Author
|
Thanks @FelixSchwarz for the vote. I have absolutely no idea how to get maintainer attention for simple PRs like this. This two-character change has been in the queue for almost one full month now. |
chrisinmtown
force-pushed
the
examples-swagger-semicolon
branch
from
31f73cb to
18c6e8b
Compare
chrisinmtown
force-pushed
the
examples-swagger-semicolon
branch
from
18c6e8b to
7109240
Compare
The extra semicolon causes a NonConformingResponseHeaders exception when response validation is enabled for the example Swagger specs.
chrisinmtown
force-pushed
the
examples-swagger-semicolon
branch
from
7109240 to
ae10f80
Compare
Contributor
|
@Ruwann any chance you could include trivial PRs like this one in 2.15.0? |
Ruwann
approved these changes
Jun 9, 2025
Member
Ruwann
left a comment
Ruwann
left a comment
There was a problem hiding this comment.
Apologies for the delay. I'll merge this one, thanks!
Contributor
Author
|
Thank you for the merge. I will create a new PR to fix the same problem, only one occurrence, in the new v2 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra semicolon causes a
NonConformingResponseHeadersexceptionwhen response validation is enabled for the Swagger spec in these examples.