Update docstring of connexion.ConnexionMiddleware.add_api#2030
Update docstring of connexion.ConnexionMiddleware.add_api#2030Ruwann merged 3 commits intospec-first:mainfrom bastantoine:patch-1
connexion.ConnexionMiddleware.add_api#2030Conversation
chrisinmtown
left a comment
chrisinmtown
left a comment
There was a problem hiding this comment.
This PR modifies a function that returns no value, to add :return: line to the function's Pydoc block. This just looks wrong to me. Please explain.
Actually this PR only updates the docstring of the function, and not the function itself. The function still returns nothing, but the docstring said that it actually returned something, which can be confusing (and I can confirm because I got confused by it 😅) |
|
You're right, I misread your PR, thanks for clarifying. +1 from me! |
Ruwann
left a comment
Ruwann
left a comment
There was a problem hiding this comment.
Thank for the PR! Although we can just delete the return documentation entirely
|
Pipeline fails due to some unrelated issue (for some reason, mypy is checking some files in a transitive dependency that got recently added) |
3 participants
Changes proposed in this pull request:
connexion.ConnexionMiddleware.add_apito match return value to actual return.