Drop Python 3.9 and add 3.13, 3.14#2088
Merged
RobbeSneyders merged 4 commits intomainfrom Oct 13, 2025
Merged
Conversation
RobbeSneyders
force-pushed
the
feature/bump-python-versions
branch
from
7aaadea to
6e16a88
Compare
RobbeSneyders
changed the title
|
|
||
| def __lt__(self, other: "SortableRoute") -> bool: | ||
| return bool(other.path_regex.match(self.path)) | ||
| return bool(other.path_regex.match(self.path)) or self.path < other.path |
Contributor
There was a problem hiding this comment.
This is so subtle. I feel it really is worth adding a comment why it was necessary.
Contributor
|
FWIW this PR dropped 3.8 (not 3.9) and added 3.14 (not 2.14). |
RobbeSneyders
changed the title
RobbeSneyders
added a commit
that referenced
this pull request
Oct 13, 2025
Typo introduced in #2088, which was silently ignored by Github.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.