Skip to content

tooltips: Custom and browser tooltip both displaying #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
grantfitzsimmons opened this issue Feb 18, 2023 · 2 comments
Closed

tooltips: Custom and browser tooltip both displaying #3014

grantfitzsimmons opened this issue Feb 18, 2023 · 2 comments
Labels
1 - Bug Incorrect behavior of the product
Milestone
7.8.6 (internal b...

Comments

@grantfitzsimmons
Copy link
Member

grantfitzsimmons commented Feb 18, 2023 •
edited
Loading

image

Screen.Recording.2023-02-17.at.9.48.18.PM.mov

Only in Firefox, not Chrome
@grantfitzsimmons grantfitzsimmons added 1 - Bug Incorrect behavior of the product pri:unknown labels Feb 18, 2023
@maxpatiiuk
Copy link
Member

Able to also replicate in Chrome, just not right away.
Happens if you quickly move your cursor between different tooltips.
Fixed

@maxpatiiuk
Copy link
Member

Did a bit of general refactoring. Please test.

Also, just noticed that disabled buttons still have modern tooltips but only in Firefox because of a React bug - facebook/react#19419 (according to the spec, events should not be fired on disabled elements, but react seems to not apply this rule consistently across browsers)

Thus, I recommend testing tooltips both in Chrome and Firefox.

This was referenced Feb 20, 2023
Closed
Closed
maxpatiiuk added a commit that referenced this issue Feb 20, 2023
@maxpatiiuk
Fix inconsistent tooltip listener cleanup logic
13eb8d4 
Fixes #3014
@maxpatiiuk maxpatiiuk added this to the 7.9.0 (internal bugs) milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - Bug Incorrect behavior of the product
Projects
None yet
Milestone
7.8.6 (internal bugs)
Development

No branches or pull requests
2 participants
@grantfitzsimmons @maxpatiiuk