Lara dsl deprecation #83
Open
+2,618
−151,878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deleted LaraiResult.java, Interpreter.java, MessageConstants.java, MasterWeaver.java, WeaverBatchTester.java from LARAI/src. - Removed LaraCore.ts import functions related to dynamic imports. - Eliminated build.gradle and settings.gradle files from LaraFramework. - Removed WeaverLauncher.java, WeaverResult.java, WeaverServer.java from LaraFramework/src. - Updated WeaverInterface build.gradle to streamline dependencies and project structure.
- Adjusted formatting and indentation in various classes to enhance code clarity. - Updated JavaDoc comments for consistency and better understanding. - Removed unnecessary commented-out code and whitespace. - Ensured consistent use of access modifiers and method annotations. - Improved method and variable naming for better comprehension. - Streamlined constructor and method implementations across multiple classes.
…ndencies and streamline project structure
…dependency; update build.gradle and settings.gradle to remove unused tdrcLibrary references.
…, and GeneratorUtils to replace StringUtils usage with native Java methods for string manipulation
…a few broken APIs and tests.
…Utils project and update related code.
joaobispo
reviewed
Jul 9, 2025
|
|
||
| import java.util.Optional; | ||
|
|
||
| public class WeaverResult { |
There was a problem hiding this comment.
This was necessary for launching weaver instances in parallel. We need to open an issue to add this feature
joaobispo
reviewed
Jul 14, 2025
| public JoinPoint getRootJp() { | ||
| return select(); | ||
| } | ||
| public abstract JoinPoint getRootJp(); |
There was a problem hiding this comment.
Verify that WeaverGenerator generates the method getRootJp() instead of select()
|
|
||
| DataKey<Boolean> LARA_LOC = KeyFactory.bool("loc").setLabel("LARA CSV with stats (LoC, #aspects, etc)"); | ||
|
|
||
| DataKey<VerboseLevel> VERBOSE = KeyFactory.enumeration("verbose", VerboseLevel.class).setLabel("Verbose Level") |
There was a problem hiding this comment.
Several packages that are using the CLI might fail because the option is no longer supported (e.g., CMake package might be using this option)
Comment on lines
29
to
31
| static String getServerFlag() { | ||
| return "server"; | ||
| } |
There was a problem hiding this comment.
Probably should be deleted, server mode can no longer be called from Java
|
|
||
| // Set store definition | ||
|
|
||
| public static StoreDefinition getStoreDefinition(WeaverEngine weaverEngine) { |
There was a problem hiding this comment.
Consider renaming to buildStoreDefinition()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.