allow validation chaining#2116
Merged
patriksvensson merged 2 commits intoMay 17, 2026
Merged
Conversation
patriksvensson
requested changes
May 12, 2026
patriksvensson
left a comment
Contributor
There was a problem hiding this comment.
Can we add tests for three chained validations as well?
patriksvensson
approved these changes
May 17, 2026
This was referenced Jun 11, 2026
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1742
Changes
This change was previously proposed in #1973 but became outdated.
This PR reintroduces the same fix on top of the current codebase.
Changes from outdated PR - tests splited into separate ones, since 1 test checked 3 different things, logic unchanged.
Please upvote 👍 this pull request if you are interested in it.