Skip to content

Remove xarray inplace calls #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spencerahill opened this issue Dec 3, 2017 · 1 comment
Closed

Remove xarray inplace calls #244

spencerahill opened this issue Dec 3, 2017 · 1 comment
Labels
data loaders low-hanging fruit

Comments

@spencerahill
Copy link
Owner

inplace is being deprecated: pydata/xarray#1756

Fortunately it looks like we only use it in one place: https://github.com/spencerahill/aospy/search?utf8=%E2%9C%93&q=inplace&type=

So should be easy fix.
@spencerahill spencerahill mentioned this issue Dec 3, 2017
Merged
spencerkclark added a commit to spencerkclark/aospy that referenced this issue Dec 4, 2017
@spencerkclark
Address review comments; close spencerahill#244
77e9d61
@spencerahill
Copy link
Owner Author

Closed by @spencerkclark as part of #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data loaders low-hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spencerahill