remove the kivy gui #8591
Merged
remove the kivy gui #8591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomberNight
force-pushed
the
202308_rm_kivy
branch
from
e017a68 to
71e4ae7
Compare
We now use the qml gui on Android, and haven't been maintaining the kivy GUI for a while.
SomberNight
force-pushed
the
202308_rm_kivy
branch
from
71e4ae7 to
b45c84f
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
Sep 6, 2023
$ git rm --force electrum/gui/kivy/theming/atlas follow-up b45c84f see spesmilo#8591
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
Sep 6, 2023
Looks like this was not fully removed. $ git rm --force electrum/gui/kivy/theming/atlas follow-up b45c84f see spesmilo#8591
This was referenced Sep 6, 2023
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use the qml gui on Android since version 4.4, and haven't been maintaining the kivy GUI for a while.
As-is, the kivy gui already has small breakages on master,
and I think e.g. #8545 and #8560 will break kivy and the ability the build a kivy apk even further, which we probably should not spend time on fixing.