PersistentPreRun only allowed once

[xh3b4sd]

Hello there. I am playing around with a command that defines a PersistentPreRun. This command has a sub command. This sub command as well wants to use PersistentPreRun. When the root command is executed its PersistentPreRun is executed as expected. When executing the sub command I expected both PersistentPreRuns to be executed, but only the sub command's PersistentPreRun is executed. I expect this as a bug. What do you guys think? Thanks for listening.

[xh3b4sd]

FYI I can work around this using PreRun for the sub command.

[amanhigh]

Yes even i felt that PersistantPreRun chaining is missing hence code get duplicated in children in order to call previous Prerun.

I feel before leaf node execution all parent PersistentPreRun should be run in order.

[kurtpeek]

In my case, the parent is the rootCmd and its PersistentPreRun() doesn't actually use the cmd or args passed into it, so I was able to work around this by calling rootCmd.PersistentPreRun(cmd, args) explicitly in the child command:

	PersistentPreRun: func(cmd *cobra.Command, args []string) {
		rootCmd.PersistentPreRun(cmd, args)
		...
	},

[github-actions]

This issue is being marked as stale due to a long period of inactivity

[mateimicu]

I also have this use case, the PersistentPreRun of the rootCmd validates some input, and for a subcommand group, I validate another set of inputs.

I worked around this with

PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
	root := cmd
	for ; root.HasParent(); root = root.Parent() {
	}
	err := root.PersistentPreRunE(cmd, args)
	...
}

I think changing now the implementations to run all the PersistentPreRunE would be a major breaking change ... If this topic develops I may have some time to contribute.

Maybe a flag can be introduced like TraverseChildren with the default on the current behaviors ?