powershell: fix non-ASCII character corruption in tab completion on Windows#2401
Open
pb2004 wants to merge 1 commit into
Open
powershell: fix non-ASCII character corruption in tab completion on Windows#2401pb2004 wants to merge 1 commit into
pb2004 wants to merge 1 commit into
Conversation
…indows On Windows, [Console]::OutputEncoding defaults to the system OEM code page rather than UTF-8, causing non-ASCII characters (e.g. Polish diacritics) in remote path names to be corrupted after tab completion — resulting in garbled output like "Za┼╝├│┼é─ç" instead of "Zażółć". Fix by temporarily switching [Console]::OutputEncoding to UTF-8 around the completion command invocation and restoring it afterwards. Fixes: rclone/rclone#9412
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
[Console]::OutputEncodingdefaults to the system OEM code pagerather than UTF-8. This causes non-ASCII characters in remote/path names to be
corrupted after tab completion.
Example:
ZażółćbecomesZa┼╝├│┼é─çReported in rclone/rclone#9412 (rclone uses cobra-generated completions).
Fix
Temporarily switch
[Console]::OutputEncodingto UTF-8 around the completioncommand invocation and restore it afterwards — the same pattern already used
in the generated script for other purposes.
Testing
Tested on Windows PowerShell 5.1 with Polish diacritics in path names.