feat: add MarkFlagNonRepeatable to reject repeated flags#2403
Closed
aspr0d wants to merge 1 commit into
Closed
Conversation
Wraps the flag's pflag.Value so that a second Set() call returns a clear error instead of silently overwriting the first value. Also forwards the BoolFlag interface so --verbose (no value) still works for boolean flags marked non-repeatable. Closes spf13#2355 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
MarkFlagNonRepeatable(name string)toCommand, which prevents a flag from being specified more than once on the command line.Currently, developers who need this behavior must define custom
pflag.Valuetypes for every flag type they use (~60 lines each), as described in #2355. This PR offers a single-call API that wraps the flag's existingValueto reject a secondSet()invocation.Implementation
nonRepeatableValue— a thin wrapper aroundpflag.Valuethat countsSet()calls and returns an error on the second one.IsBoolFlag()is forwarded so--verbose(no value) still works for boolean flags.Example
Test plan
TestNonRepeatableFlag— 5 cases: single string, repeated string, single bool, repeated bool, no flagsgo test ./...)go build ./...andgo vet ./...cleanCloses #2355