Sort option #51
Merged
Sort option #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to improve error reporting we first need to communicate typed error objects from the checking functions instead of error messages, where we can't (easily and reliably) recover the error details anymore. Error objects know how to format themselves, so we print them directly, and let them do their internal formatting. Signed-off-by: Rodrigo Tobar <[email protected]>
Signed-off-by: Rodrigo Tobar <[email protected]>
Users can specify now a command-line option to sort errors before they are reported to stdout. When no option is given, errors are reported as they are generated, preserving backwards compatibility. When given, a comma-delimited list of field names must be given, with errors being sorted by the first field, then the second, and so on. Signed-off-by: Rodrigo Tobar <[email protected]>
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea on how to tackle #50. Not fully convinced with the list of supported fields ("line" on its own doesn't have much value), and probably some things can be improved, but overall it's working as expected.