-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add Unicode Normalization for Search Indexing #13384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tokuhirom
wants to merge
12
commits into
sphinx-doc:master
Choose a base branch
from
tokuhirom:feature-html_search_unicode_normalization
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a228fad
Add Unicode Normalization for Search Indexing
tokuhirom 629820f
add js test case for unicode normalization
tokuhirom 1c2443e
Merge branch 'master' into feature-html_search_unicode_normalization
tokuhirom 6fb1fb7
Use single rst files to test the normalization.
tokuhirom 20d2749
just test the return value of the _parseQuery.
tokuhirom fac3a53
Make 'NFKD' as a default value of the unicode normalization
tokuhirom 79069f2
Merge branch 'master' into feature-html_search_unicode_normalization
tokuhirom 9476676
Merge branch 'master' into feature-html_search_unicode_normalization
tokuhirom 2af0301
Revert "just test the return value of the _parseQuery."
tokuhirom 9ae1e39
re-add 'should parse queries with half-width and full-width character…
tokuhirom f03b8e1
move cleanup process to the `afterEach` step.
tokuhirom 661ee11
Merge branch 'master' into feature-html_search_unicode_normalization
tokuhirom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -276,7 +276,15 @@ const Search = { | |||||||||||||||||||||
else Search.deferQuery(query); | ||||||||||||||||||||||
}, | ||||||||||||||||||||||
|
||||||||||||||||||||||
_normalizeQuery: (query, form) => { | ||||||||||||||||||||||
return query.normalize(form); | ||||||||||||||||||||||
}, | ||||||||||||||||||||||
|
||||||||||||||||||||||
_parseQuery: (query) => { | ||||||||||||||||||||||
if (DOCUMENTATION_OPTIONS.SEARCH_UNICODE_NORMALIZATION) { | ||||||||||||||||||||||
query = Search._normalizeQuery(query, DOCUMENTATION_OPTIONS.SEARCH_UNICODE_NORMALIZATION); | ||||||||||||||||||||||
} | ||||||||||||||||||||||
|
||||||||||||||||||||||
// stem the search terms and add them to the correct list | ||||||||||||||||||||||
Comment on lines
283
to
288
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||
const stemmer = new Stemmer(); | ||||||||||||||||||||||
const searchTerms = new Set(); | ||||||||||||||||||||||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
html_search_unicode_normalization = 'NFKC' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Sphinx | ||
====== | ||
|
||
This is the main page of the ``normalization`` test project. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,5 @@ lorem ipsum | |
模块中 CAS service部分 | ||
|
||
可以Chinesetesttwo查看 | ||
|
||
Python |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.