fix(snippets): update full screen snippets selectors#1049
fix(snippets): update full screen snippets selectors#1049kyrie25 merged 4 commits intospicetify:mainfrom
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughUpdated two CSS snippet entries in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kyrie25
left a comment
There was a problem hiding this comment.
Was thinking of changing it to use
[data-testid="fullscreen-mode-button"]instead but I'm unsure if these are always set. Do you have an opinion on this?
You should, and it is definitely better than using SVG path as a selector.
… relying on svg path
Hide Full Screen Button selector
Hide Full Screen Button selector
Was thinking of changing it to use
[data-testid="fullscreen-mode-button"]instead but I'm unsure if these are always set. Do you have an opinion on this?