Skip to content

feat: don't install themes if current_theme isn't marketplace#673

Merged
theRealPadster merged 1 commit intospicetify:mainfrom
SunsetTechuila:themes
Dec 18, 2023
Merged

feat: don't install themes if current_theme isn't marketplace#673
theRealPadster merged 1 commit intospicetify:mainfrom
SunsetTechuila:themes

Conversation

@SunsetTechuila
Copy link
Copy Markdown
Contributor

No description provided.

@SunsetTechuila SunsetTechuila requested a review from a team as a code owner December 17, 2023 15:24
@SunsetTechuila SunsetTechuila requested review from rxri and removed request for a team December 17, 2023 15:24
@CharlieS1103
Copy link
Copy Markdown
Member

Is this something we really want?

@SunsetTechuila
Copy link
Copy Markdown
Contributor Author

SunsetTechuila commented Dec 17, 2023

Since themes don't work correctly without setting current_theme to marketplace, I think it is

@SunsetTechuila
Copy link
Copy Markdown
Contributor Author

I've seen a lot of people having issues with themes from the marketplace because they didn't do that

@theRealPadster theRealPadster merged commit 700bb74 into spicetify:main Dec 18, 2023
@SunsetTechuila SunsetTechuila deleted the themes branch December 18, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants