feat: option to show archived repos & archived tag#679
feat: option to show archived repos & archived tag#679SunsetTechuila merged 3 commits intospicetify:mainfrom SunsetTechuila:archive
archived tag#679Conversation
SunsetTechuila
requested review from
CharlieS1103 and
theRealPadster
and removed request for
a team and
CharlieS1103
SunsetTechuila
changed the title
archived tagarchived tag
SunsetTechuila
changed the title
archived tagarchived tag
theRealPadster
left a comment
theRealPadster
left a comment
There was a problem hiding this comment.
Looks good to me. Just some linting stuff.
What linter should I use to see the warnings? Eslint doesn't show any. And every formatter removes those spaces |
Co-authored-by: Isaac <padspambox@gmail.com>
|
Hmm, not sure, is it not just ESLint? I always do spaces around curly brackets. Says ESLint? |
you are showing a regular js, not jsx |
It's in the |
I have committed suggestion for the |
Ah, maybe the ESLint rules don't apply to the tsx then, but I think it makes sense to follow the same conventions across both. |
Are you sure? JSX has different conventions. That's why eslint shows nothing |
|
It looks like it's an option. I'm sure there are different style guides, but I'm used to using spaces and regardless which we do, I think we should be consistent between js/jsx files in the same project. |
|
|
ew in jsx you shouldn't have curly spacing. looks bad af |
Literally looks the exact same as in JS. But okay if it's all done without spaces currently then I guess let's leave it. 🤷 |
tbh I have never seen JSX code with style like this. JS and JSX are not the same and shouldn't be connected with styles. JS has imports with curly spacing because that's how "it was designed" and JSX was designed to not have them |
3 participants
No description provided.