fix(snippets): improve Smooth Progress/Volume Bar code#680
Merged
theRealPadster merged 6 commits intomainfrom Jan 24, 2024
Merged
fix(snippets): improve Smooth Progress/Volume Bar code#680theRealPadster merged 6 commits intomainfrom
Smooth Progress/Volume Bar code#680theRealPadster merged 6 commits intomainfrom
Conversation
SunsetTechuila
suggested changes
Jan 24, 2024
Contributor
SunsetTechuila
left a comment
There was a problem hiding this comment.
i think this will be better:
@property --progress-bar-transform {
inherits: true;
initial-value: 0%;
syntax: '<percentage>';
}
.progress-bar {
transition: --progress-bar-transform 1s linear !important;
}
.progress-bar:hover, .progress-bar:active {
transition-duration: 150ms !important;
}
Member
Author
|
Hmm, okay, but that makes it do the jittery thing when you hover over it. |
Member
Author
|
Seems like if you take out the |
Contributor
You can wait for this to be merged then |
Member
Author
I think it works well enough if you remove the |
Contributor
|
as you wish |
…ify-marketplace into fix/smooth-progress-bar
Smooth Progress/Volume bar code
SunsetTechuila
approved these changes
Jan 24, 2024
Smooth Progress/Volume bar codeSmooth Progress/Volume Bar code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was using the default ease timing function, so while it was smoother, it still had definite start/stop points. This makes it a fully smooth linear transition with no discernable steps.