Skip to content

fix(components): add necessary elements for 1.2.34 #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rxri merged 2 commits into from
Mar 26, 2024
+3 −3
Merged

fix(components): add necessary elements for 1.2.34 #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dcad6d
fix(TabBar): add another resize host selector
rxri Mar 26, 2024
8b98ff3
fix: add another element for viewport
rxri Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Grid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ class Grid extends React.Component<
this.gridUpdateTabs = this.updateTabs.bind(this);
this.gridUpdatePostsVisual = this.updatePostsVisual.bind(this);

const viewPort = document.querySelector(".os-viewport");
const viewPort = document.querySelector(".os-viewport") ?? document.querySelector("#main .main-view-container__scroll-node");
this.checkScroll = this.isScrolledBottom.bind(this);
if (viewPort) {
viewPort.addEventListener("scroll", this.checkScroll);
Expand All @@ -522,7 +522,7 @@ class Grid extends React.Component<
*/
componentWillUnmount(): void {
this.gridUpdateTabs = this.gridUpdatePostsVisual = null;
const viewPort = document.querySelector(".os-viewport");
const viewPort = document.querySelector(".os-viewport") ?? document.querySelector("#main .main-view-container__scroll-node");
if (viewPort) {
this.lastScroll = viewPort.scrollTop;
viewPort.removeEventListener("scroll", this.checkScroll);
Expand Down
2 changes: 1 addition & 1 deletion src/components/TabBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export const TopBarContent = (props: {
activeLink: string;
switchCallback: (option: Option) => void;
}) => {
const resizeHost = document.querySelector(".Root__main-view .os-resize-observer-host");
const resizeHost = document.querySelector(".Root__main-view .os-resize-observer-host") ?? document.querySelector(".Root__main-view .os-size-observer");
if (!resizeHost) return null;

const [windowSize, setWindowSize] = useState(resizeHost.clientWidth);
Expand Down