feat: switch to biome to ensure consistency & apply various fixes#759
Merged
feat: switch to biome to ensure consistency & apply various fixes#759
Conversation
afonsojramos
changed the title
rxri
approved these changes
May 21, 2024
Member
|
Why are we using no trailing commas? Should be "always" for more readable diffs. |
Member
Should be "es5". Didn't notice it. Not really much of the deal because the marketplace code is going to be replaced soon |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo contains multiple files with different types of spacing, formatting done via eslint, which is not recommended by the team itself, so this pr introduces biome, which has already been implemented in spicetify/cli.