feat(snippets): add a Dynamic Left Sidebar#791
Merged
theRealPadster merged 21 commits intospicetify:mainfrom Jul 5, 2024
Ender-Wang:main
Merged
feat(snippets): add a Dynamic Left Sidebar#791theRealPadster merged 21 commits intospicetify:mainfrom Ender-Wang:main
Dynamic Left Sidebar#791theRealPadster merged 21 commits intospicetify:mainfrom
Ender-Wang:main
Conversation
Now all sides have equal margins.
A New Hover Panel that servers the same purpose as the legacy 'Hover Panels', but only for the left sidebar and without modifying any other elements.
Makes the left sidebar dynamic, so it only shows when you hover over it and pushes the main content to the right.
theRealPadster
approved these changes
Jul 5, 2024
Member
|
Does this replace the other new hover panel snippet? Should we remove it in the code? |
Contributor
Author
Function-wise, it replaces all hovering left sidebar snippets, both can be there in case someone prefers hovering instead of this dynamic one. |
Member
|
Oh, the hover one goes on top of the content vs this moves it to the side? |
Contributor
Author
|
Exactly. This one pushes the main view to the right without blocking anything below it. |
theRealPadster
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic Left Sidebar Description
Motivation
New Hover Panelfeat(snippets): add aNew Hover Panel#778 that fixed the legacyHover Panels.But after some time using it, I found it blocks the beginning of a playlist(can be anything) when I hover the left sidebar that activates the hovering, which is the expected hovering behavior, but it's kinda annoying. Then I made this one to be like when you hover the left side edge, the LeftSidebar appears and pushes the content to the right so nothing is blocked.