fix(snippet/switch-sidebars): reposition resize handle#881
Merged
kyrie25 merged 2 commits intospicetify:mainfrom Jan 21, 2025
Merged
fix(snippet/switch-sidebars): reposition resize handle#881kyrie25 merged 2 commits intospicetify:mainfrom
kyrie25 merged 2 commits intospicetify:mainfrom
Conversation
kyrie25
requested changes
Jan 21, 2025
Member
kyrie25
left a comment
kyrie25
left a comment
There was a problem hiding this comment.
Lint code & commit only your changes, don't reformat the entire file
kyrie25
changed the title
kyrie25
approved these changes
Jan 21, 2025
Contributor
Author
|
Thank you :D |
|
Thanks for the effort. However, it's not fully behaving as it should (although better). spicetify.mp4 |
Contributor
Author
|
Yeah the dragging behaviour is still the same i.e. reversed or pre-switching context. You can drag them off the edge of the application window. Afaik there isn't really a way to alter that via snippets. Regardless, I really like this snippet and use it a lot so I hope someone can improve on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #880. Fixed resize handle positions upon switching sidebar positions. Drag to resize works in reverse / pre-switching context.