svid.v1 client: add support for building WIT-SVIDs#7132
Open
sorindumitru wants to merge 3 commits into
Open
Conversation
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
sorindumitru
requested review from
MarcosDY,
amartinezfayo,
evan2645 and
rturner3
as code owners
There was a problem hiding this comment.
Pull request overview
Adds client-side support in the SPIRE Agent for minting WIT-SVIDs via the svid.v1 server API, including a new client method and accompanying unit tests.
Changes:
- Introduces a
WITSVIDresult type and addsNewWITSVIDs()to the agent client interface. - Implements batched WIT-SVID minting via
BatchNewWITSVID, including per-result status handling and conversion totime.Time. - Adds unit test coverage and a fake SVID server implementation for
BatchNewWITSVID.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/agent/client/client.go | Adds WITSVID, client interface method, and the batch RPC plumbing to mint WIT-SVIDs. |
| pkg/agent/client/client_test.go | Adds tests and fake server support for the new WIT-SVID batch minting client method. |
Comment on lines
+422
to
+425
| pkixPublicKey, err := x509.MarshalPKIXPublicKey(publicKey) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.