Skip to content

cli: spin up default to -f spin.toml #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2022
Merged

cli: spin up default to -f spin.toml #209

merged 1 commit into from
Mar 22, 2022

Conversation

lann
Copy link
Collaborator

@lann lann commented Mar 22, 2022

Fixes #166

(None, None) => bail!("Must specify app file or bindle id"),
(Some(app), None) => spin_loader::from_file(app, working_dir).await?,
(app, None) => {
let manifest_file = app
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could simplify this to keep the structure of the match statement clear, but I can't see a good way to do it...

@lann lann merged commit 47e9107 into main Mar 22, 2022
@lann lann deleted the default-spin-toml branch March 22, 2022 23:16
Copy link
Collaborator

@michelleN michelleN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lann lann mentioned this pull request Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spin up without having to pass -f flag
4 participants