Allow external configuration of "keep resident" options #3065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
approved these changes
Mar 29, 2025
|
@alexcrichton you'll need to sign your commit and this will automatically merge. |
These options control the behavior of Wasmtime's pooling allocator and can have a big effect on performance, so add environment variables for them so they can at least be tuned after-the-fact for a build of Spin. Signed-off-by: Alex Crichton <[email protected]>
auto-merge was automatically disabled
March 31, 2025 14:21
Head branch was pushed to by a user without write access
alexcrichton
force-pushed
the
tune-keep-resident-options
branch
from
713c35e to
277854f
Compare
|
Apologies I always forget that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options control the behavior of Wasmtime's pooling allocator and can have a big effect on performance, so add environment variables for them so they can at least be tuned after-the-fact for a build of Spin.