-
Notifications
You must be signed in to change notification settings - Fork 271
ci(.github): add fossa.yml #3138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
92e5413
to
d4b4e33
Compare
We had a successful scan earlier (https://github.com/spinframework/spin/actions/runs/15053169359) but noticed the errors parsing a few go templates, so @kate-goldenring and I figured we'd learn up on using the .fossa.yml config to exclude them (eg exclude all |
dc80305
to
0b8803e
Compare
I'm continuing to run into a few issues so have sent an email to fossa support, copying Kate. |
e7b0731
to
b0b317d
Compare
Back up for review. Hadn't yet heard back from support. Deferring use of a |
Lastly, and this can be a follow-up if we'd like to further deliberate, but I think it may be worthwhile to just hard-code the push-only FOSSA_API_KEY into the workflow. FOSSA claims edit: updated/de-secreted |
sgtm; seems pretty common: https://github.com/search?q=%2FFOSSA_API_KEY%3A+%22%3F%5B%5E%24%5D%2F+path%3A%2F%5E.github%2F&type=code |
Signed-off-by: Vaughn Dice <[email protected]> Co-authored-by: Kate Goldenring <[email protected]> Co-authored-by: Lann <[email protected]>
I am trying to think through how we are supposed to use / interpret these scans. Right now, failures / invalid licenses do not cause the action to fail. Are maintainers supposed to periodically check the results and amend license issues? Are we hopping that once we add the fossa config we can then make failures lead to failed CI? |
@kate-goldenring right, I think perhaps we'll want to revisit incorporating the fossa test command -- and most likely something in the form where we check the diff on the current PR/branch revision as mentioned here. I can experiment with this here. I think failing the CI check would be the way to go -- but as a prerequisite we'd want a blank slate and would need to first address the current scan issues. Otherwise, as you mention, the action always succeeds and it would be up to the maintainers to periodically check in -- which isn't ideal. |
Signed-off-by: Vaughn Dice <[email protected]>
😭 Needs a full-access (and thus sensitive) API key but then forks won't be able to use it when in the form of a GH secret, negating the main utility for running
I'm beginning to think for this first phase we just check the FOSSA box by only running fossa analyze (which as mentioned always succeeds and publishes failures to the fossa website) -- and relying on maintainer attention to the scan results in the near-term 🫤. (Maybe add a badge to the README to put a bit more pressure on us?) Or punt again and put back into draft to revisit when I/we have renewed gumption.
Maybe it's worth trying to address the scan errors to get to a blank state; I'll look into this in the meantime. |
Adds a workflow to run FOSSA scans for this project (ref CNCF Onboarding (view))
Supersedes #3137 to test workflow from branch on origin.