Enable running wkg oci packages as bare Wasm
#3361
Merged
+115
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
requested review from
fibonacci1729,
jsturtevant,
kate-goldenring,
lann,
michelleN and
vdice
itowlson
commented
Nov 24, 2025
| .with_context(|| format!("OCI config {} is not JSON", quoted_path(&lockfile_path)))?; | ||
|
|
||
| if locked_json.get("spin_lock_version").is_some() { | ||
| let mut locked_app = LockedApp::from_json(&locked_content).with_context(|| { |
Collaborator
Author
There was a problem hiding this comment.
This chunk (to line 89) has not changed from line 51ff in the existing code: it has just moved down and been indented because of going inside the "is it a LockedApp" check. If I've made this function too long and/or intricate (as I strongly suspect I have), yell at me and I'll split the arms of the if into separate helpers.
lann
approved these changes
Nov 24, 2025
fibonacci1729
approved these changes
Nov 24, 2025
kate-goldenring
approved these changes
Nov 24, 2025
Contributor
kate-goldenring
left a comment
kate-goldenring
left a comment
There was a problem hiding this comment.
LGTM but it would be great to add an integration test for this.
itowlson
force-pushed
the
oci-bare-wasm-packages
branch
from
651813b to
0e0a3c9
Compare
jsturtevant
reviewed
Nov 24, 2025
jsturtevant
approved these changes
Nov 24, 2025
itowlson
force-pushed
the
oci-bare-wasm-packages
branch
2 times, most recently
from
972ce24 to
263b318
Compare
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
oci-bare-wasm-packages
branch
from
263b318 to
fd6022f
Compare
Collaborator
Author
|
@kate-goldenring integration test added (although right now it is going about as well as you'd expect, fie) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3360.
I tested this against
wkg oci push:Note that I've only tested to the "hello world" level: if we believe we need to try this on a wider range of binaries then let's chat about desirable test coverage. I'm also not sure if there's a good way to automate testing - open to advice!
It would be nice to also do it for proper packages (
wkg publish) but that's probably going to need a bit more investigation and thinky-designy-sort-of-work.