Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Nov 10, 2025

Since we're on the 2024 edition, bumping the msrv is no longer considered a breaking change because of this change. 81% of crates.io traffic comes from 1.86 or later, compared to 89% that use 1.85 or later, so we don't lose a huge amount the potential ecosystem.
This also unblocks codspeed with much better capabilities at "seeing" inlined code, which is very valuable here.

@AdamGS AdamGS requested a review from a10y November 10, 2025 11:39
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 10, 2025

CodSpeed Performance Report

Merging #149 will improve performances by ×2

Comparing adamg/bump-msrv-divan (9cae91f) with develop (1f3875d)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 1 improvement
✅ 31 untouched

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
WallTime compress-twobytes 2 ns 1 ns ×2

@a10y
Copy link
Contributor

a10y commented Nov 10, 2025

Yea this is probably fine. But also, I'm assuming there's a way to configure which toolchain codspeed uses?

@AdamGS
Copy link
Contributor Author

AdamGS commented Nov 10, 2025

Its possible (RUSTUP_TOOLCHAIN) but it seems like just more complexity. We can just hold this until 1.86 becomes as popular as 1.85 is now (taken from the bottom of this page)/is a year old or some other popularity metric.

@AdamGS AdamGS merged commit 4bc16f1 into develop Nov 11, 2025
6 checks passed
@AdamGS AdamGS deleted the adamg/bump-msrv-divan branch November 11, 2025 09:58
@github-actions github-actions bot mentioned this pull request Nov 3, 2025
AdamGS pushed a commit that referenced this pull request Nov 11, 2025
## 🤖 New release

* `fsst-rs`: 0.5.5 -> 0.5.6 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.5.6](v0.5.5...v0.5.6) -
2025-11-11

### Other

- *(deps)* update codspeedhq/action digest to 6a8e2b8
([#147](#147))
- Bump MSRV to 1.86 (and codspeed)
([#149](#149))
- *(deps)* lock file maintenance
([#146](#146))
- Reuse binary heap during training
([#144](#144))
- *(deps)* lock file maintenance
([#141](#141))
- *(deps)* update actions/upload-artifact action to v5
([#139](#139))
- *(deps)* update codspeedhq/action digest to 4348f63
([#138](#138))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants