Skip to content

Fix clippy warnings in latest rust version #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

rydrman
Copy link
Collaborator

@rydrman rydrman commented Sep 27, 2022

The other branch CI pipelines are all failing now...

@rydrman rydrman added the maintenance Cleanup, upgrades, etc label Sep 27, 2022
@rydrman rydrman requested a review from jrray September 27, 2022 04:14
@rydrman rydrman self-assigned this Sep 27, 2022
@rydrman rydrman mentioned this pull request Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #514 (43d1609) into master (af2cf6b) will increase coverage by 0.03%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
+ Coverage   67.51%   67.54%   +0.03%     
==========================================
  Files         276      276              
  Lines       18879    18869      -10     
==========================================
- Hits        12746    12745       -1     
+ Misses       6133     6124       -9     
Impacted Files Coverage Δ
crates/spfs/src/graph/tree.rs 53.84% <0.00%> (+5.00%) ⬆️
crates/spfs/src/proto/conversions.rs 0.00% <0.00%> (ø)
crates/spk-storage/src/storage/repository.rs 77.55% <50.00%> (ø)
crates/spk-storage/src/storage/spfs.rs 83.85% <66.66%> (ø)
...tes/spk-schema/crates/validators/src/validators.rs 70.73% <70.00%> (+2.54%) ⬆️
crates/spfs/src/storage/manifest_test.rs 97.36% <100.00%> (-0.07%) ⬇️
...es/spk-schema/crates/foundation/src/version/mod.rs 86.03% <100.00%> (+0.47%) ⬆️
crates/spk-solve/src/io.rs 46.15% <100.00%> (+0.16%) ⬆️
crates/spfs/src/storage/repository.rs 79.06% <0.00%> (+2.32%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rydrman rydrman merged commit e75eed1 into master Sep 27, 2022
@rydrman rydrman deleted the clippy-updates branch September 27, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Cleanup, upgrades, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant