-
Notifications
You must be signed in to change notification settings - Fork 7
Update splitChanges response #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
ba303d8
Persistent storage
gthea 1ade063
WIP
gthea 2b2b424
SqLite persistent storage tests
gthea e292005
Tests
gthea bae1f83
Fixes
gthea c1c96dd
Add exception handling
gthea ad23322
More tests
gthea 2fc3f2e
Add nullability annotations
gthea 96bca34
Merge branch 'SDKS-9357_baseline' into SDKS-9439_1
gthea a8bff33
Prep for ParserCommons
gthea 537ed77
Tests for lazy storage provider
gthea 7519aca
Fix impl
gthea 724c681
Storage change & matcher implementation
gthea 2d221fb
Temp parser for RBS storage
gthea 24b8c6b
Fix
gthea f042de3
Fix test
gthea cfa0c6c
In RBS matcher test
gthea 0cbde4c
RBS parser
gthea 4ddb4aa
Simplify initialization
gthea 509204e
Fix tests
gthea 83d4550
Merge branch 'SDKS-9357_baseline' into SDKS-9439_3
gthea 2672fbf
WIP
gthea fa22170
Manual test updates
gthea 0aabcaa
Change mock .json
gthea d714903
UT migrated
gthea 9f29fb3
WIP tests migration
gthea 7ffc626
Tests migration continued
gthea c0c380d
Fix
gthea 5cf6449
Merge branch 'SDKS-9357_baseline' into SDKS-9437
gthea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
335 changes: 170 additions & 165 deletions
335
src/androidTest/assets/attributes_test_split_change.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,182 +1,187 @@ | ||
| { | ||
| "splits":[ | ||
| "ff": { | ||
| "splits": [ | ||
| { | ||
| "trafficTypeName":"client", | ||
| "name":"workm", | ||
| "trafficAllocation":100, | ||
| "trafficAllocationSeed":147392224, | ||
| "seed":524417105, | ||
| "status":"ACTIVE", | ||
| "killed":false, | ||
| "defaultTreatment":"on", | ||
| "changeNumber":1602796638344, | ||
| "algo":2, | ||
| "configurations":{ | ||
|
|
||
| }, | ||
| "conditions":[ | ||
| { | ||
| "conditionType":"ROLLOUT", | ||
| "matcherGroup":{ | ||
| "combiner":"AND", | ||
| "matchers":[ | ||
| { | ||
| "keySelector":{ | ||
| "trafficType":"client", | ||
| "attribute":"num_value" | ||
| }, | ||
| "matcherType":"EQUAL_TO", | ||
| "negate":false, | ||
| "userDefinedSegmentMatcherData":null, | ||
| "whitelistMatcherData":null, | ||
| "unaryNumericMatcherData":{ | ||
| "dataType":"NUMBER", | ||
| "value":10 | ||
| }, | ||
| "betweenMatcherData":null, | ||
| "booleanMatcherData":null, | ||
| "dependencyMatcherData":null, | ||
| "stringMatcherData":null | ||
| } | ||
| ] | ||
| }, | ||
| "partitions":[ | ||
| { | ||
| "treatment":"on_num_10", | ||
| "size":100 | ||
| "trafficTypeName": "client", | ||
| "name": "workm", | ||
| "trafficAllocation": 100, | ||
| "trafficAllocationSeed": 147392224, | ||
| "seed": 524417105, | ||
| "status": "ACTIVE", | ||
| "killed": false, | ||
| "defaultTreatment": "on", | ||
| "changeNumber": 1602796638344, | ||
| "algo": 2, | ||
| "configurations": { | ||
| }, | ||
| "conditions": [ | ||
| { | ||
| "conditionType": "ROLLOUT", | ||
| "matcherGroup": { | ||
| "combiner": "AND", | ||
| "matchers": [ | ||
| { | ||
| "keySelector": { | ||
| "trafficType": "client", | ||
| "attribute": "num_value" | ||
| }, | ||
| { | ||
| "treatment":"off", | ||
| "size":0 | ||
| } | ||
| ], | ||
| "label":"rule 1" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "conditionType":"ROLLOUT", | ||
| "matcherGroup":{ | ||
| "combiner":"AND", | ||
| "matchers":[ | ||
| { | ||
| "keySelector":{ | ||
| "trafficType":"client", | ||
| "attribute":"str_value" | ||
| "matcherType": "EQUAL_TO", | ||
| "negate": false, | ||
| "userDefinedSegmentMatcherData": null, | ||
| "whitelistMatcherData": null, | ||
| "unaryNumericMatcherData": { | ||
| "dataType": "NUMBER", | ||
| "value": 10 | ||
| }, | ||
| "matcherType":"MATCHES_STRING", | ||
| "negate":false, | ||
| "userDefinedSegmentMatcherData":null, | ||
| "whitelistMatcherData":null, | ||
| "unaryNumericMatcherData":null, | ||
| "betweenMatcherData":null, | ||
| "booleanMatcherData":null, | ||
| "dependencyMatcherData":null, | ||
| "stringMatcherData":"yes" | ||
| } | ||
| ] | ||
| }, | ||
| "partitions":[ | ||
| { | ||
| "treatment":"on_str_yes", | ||
| "size":100 | ||
| "betweenMatcherData": null, | ||
| "booleanMatcherData": null, | ||
| "dependencyMatcherData": null, | ||
| "stringMatcherData": null | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "treatment":"off", | ||
| "size":0 | ||
| } | ||
| ], | ||
| "label":"rule 2" | ||
| "partitions": [ | ||
| { | ||
| "treatment": "on_num_10", | ||
| "size": 100 | ||
| }, | ||
| { | ||
| "treatment": "off", | ||
| "size": 0 | ||
| } | ||
| ], | ||
| "label": "rule 1" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "trafficTypeName":"client", | ||
| "name":"workm1", | ||
| "trafficAllocation":100, | ||
| "trafficAllocationSeed":147392224, | ||
| "seed":524417105, | ||
| "status":"ACTIVE", | ||
| "killed":false, | ||
| "defaultTreatment":"on", | ||
| "changeNumber":1602796638344, | ||
| "algo":2, | ||
| "configurations":{ | ||
|
|
||
| }, | ||
| "conditions":[ | ||
| "conditionType": "ROLLOUT", | ||
| "matcherGroup": { | ||
| "combiner": "AND", | ||
| "matchers": [ | ||
| { | ||
| "conditionType":"ROLLOUT", | ||
| "matcherGroup":{ | ||
| "combiner":"AND", | ||
| "matchers":[ | ||
| { | ||
| "keySelector":{ | ||
| "trafficType":"client", | ||
| "attribute":"num_value_a" | ||
| }, | ||
| "matcherType":"EQUAL_TO", | ||
| "negate":false, | ||
| "userDefinedSegmentMatcherData":null, | ||
| "whitelistMatcherData":null, | ||
| "unaryNumericMatcherData":{ | ||
| "dataType":"NUMBER", | ||
| "value":20 | ||
| }, | ||
| "betweenMatcherData":null, | ||
| "booleanMatcherData":null, | ||
| "dependencyMatcherData":null, | ||
| "stringMatcherData":null | ||
| } | ||
| ] | ||
| }, | ||
| "partitions":[ | ||
| { | ||
| "treatment":"on_num_20", | ||
| "size":100 | ||
| }, | ||
| { | ||
| "treatment":"off", | ||
| "size":0 | ||
| } | ||
| ], | ||
| "label":"rule 3" | ||
| "keySelector": { | ||
| "trafficType": "client", | ||
| "attribute": "str_value" | ||
| }, | ||
| "matcherType": "MATCHES_STRING", | ||
| "negate": false, | ||
| "userDefinedSegmentMatcherData": null, | ||
| "whitelistMatcherData": null, | ||
| "unaryNumericMatcherData": null, | ||
| "betweenMatcherData": null, | ||
| "booleanMatcherData": null, | ||
| "dependencyMatcherData": null, | ||
| "stringMatcherData": "yes" | ||
| } | ||
| ] | ||
| ] | ||
| }, | ||
| "partitions": [ | ||
| { | ||
| "treatment": "on_str_yes", | ||
| "size": 100 | ||
| }, | ||
| { | ||
| "treatment": "off", | ||
| "size": 0 | ||
| } | ||
| ], | ||
| "label": "rule 2" | ||
| }, | ||
| { | ||
| "conditionType":"ROLLOUT", | ||
| "matcherGroup":{ | ||
| "combiner":"AND", | ||
| "matchers":[ | ||
| { | ||
| "keySelector":{ | ||
| "trafficType":"client", | ||
| "attribute":"str_value_a" | ||
| "trafficTypeName": "client", | ||
| "name": "workm1", | ||
| "trafficAllocation": 100, | ||
| "trafficAllocationSeed": 147392224, | ||
| "seed": 524417105, | ||
| "status": "ACTIVE", | ||
| "killed": false, | ||
| "defaultTreatment": "on", | ||
| "changeNumber": 1602796638344, | ||
| "algo": 2, | ||
| "configurations": { | ||
| }, | ||
| "conditions": [ | ||
| { | ||
| "conditionType": "ROLLOUT", | ||
| "matcherGroup": { | ||
| "combiner": "AND", | ||
| "matchers": [ | ||
| { | ||
| "keySelector": { | ||
| "trafficType": "client", | ||
| "attribute": "num_value_a" | ||
| }, | ||
| "matcherType":"MATCHES_STRING", | ||
| "negate":false, | ||
| "userDefinedSegmentMatcherData":null, | ||
| "whitelistMatcherData":null, | ||
| "unaryNumericMatcherData":null, | ||
| "betweenMatcherData":null, | ||
| "booleanMatcherData":null, | ||
| "dependencyMatcherData":null, | ||
| "stringMatcherData":"no" | ||
| } | ||
| ] | ||
| }, | ||
| "partitions":[ | ||
| { | ||
| "treatment":"on_str_no", | ||
| "size":100 | ||
| "matcherType": "EQUAL_TO", | ||
| "negate": false, | ||
| "userDefinedSegmentMatcherData": null, | ||
| "whitelistMatcherData": null, | ||
| "unaryNumericMatcherData": { | ||
| "dataType": "NUMBER", | ||
| "value": 20 | ||
| }, | ||
| "betweenMatcherData": null, | ||
| "booleanMatcherData": null, | ||
| "dependencyMatcherData": null, | ||
| "stringMatcherData": null | ||
| } | ||
| ] | ||
| }, | ||
| "partitions": [ | ||
| { | ||
| "treatment": "on_num_20", | ||
| "size": 100 | ||
| }, | ||
| { | ||
| "treatment": "off", | ||
| "size": 0 | ||
| } | ||
| ], | ||
| "label": "rule 3" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "conditionType": "ROLLOUT", | ||
| "matcherGroup": { | ||
| "combiner": "AND", | ||
| "matchers": [ | ||
| { | ||
| "treatment":"off", | ||
| "size":0 | ||
| "keySelector": { | ||
| "trafficType": "client", | ||
| "attribute": "str_value_a" | ||
| }, | ||
| "matcherType": "MATCHES_STRING", | ||
| "negate": false, | ||
| "userDefinedSegmentMatcherData": null, | ||
| "whitelistMatcherData": null, | ||
| "unaryNumericMatcherData": null, | ||
| "betweenMatcherData": null, | ||
| "booleanMatcherData": null, | ||
| "dependencyMatcherData": null, | ||
| "stringMatcherData": "no" | ||
| } | ||
| ], | ||
| "label":"rule 3" | ||
| ] | ||
| }, | ||
| "partitions": [ | ||
| { | ||
| "treatment": "on_str_no", | ||
| "size": 100 | ||
| }, | ||
| { | ||
| "treatment": "off", | ||
| "size": 0 | ||
| } | ||
| ], | ||
| "label": "rule 3" | ||
| } | ||
| ], | ||
| "since":1602796638344, | ||
| "till":1602796638344 | ||
| ], | ||
| "since": 1602796638344, | ||
| "till": 1602796638344 | ||
| }, | ||
| "rbs": { | ||
| "d": [], | ||
| "s": 1602796638341, | ||
| "t": 1602796638341 | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"d"?