Skip to content

Support overwriting default options #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 15, 2025
Merged

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Apr 10, 2025

React SDK

What did you accomplish?

Added updateOnSdk<Event> props to the SplitFactoryProvider component to allow overwriting the default value of configuration options of the library useSplitClient and useSplitTreatments hooks.

How do we test the changes introduced in this PR?

Added unit tests for test coverage.

Extra Notes

@EmilianoSanchez EmilianoSanchez changed the base branch from development to upgrade_dev_dependencies April 11, 2025 21:57
@EmilianoSanchez EmilianoSanchez changed the title Support overwriting default options [WIP] Support overwriting default options Apr 14, 2025
@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review April 14, 2025 16:49
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner April 14, 2025 16:49
Base automatically changed from upgrade_dev_dependencies to development April 15, 2025 13:13
Copy link

@EmilianoSanchez EmilianoSanchez merged commit 8bdaf82 into development Apr 15, 2025
7 checks passed
@EmilianoSanchez EmilianoSanchez deleted the default_options branch April 15, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants