Skip to content

Conversation

@szymonpk
Copy link
Contributor

@szymonpk szymonpk commented Apr 7, 2022

Proposed changes

Metrics like emit_count, num_errors, and others are missing when 2.0.1
is used [1], [2].

Also, bump .ruby-version to 2.7.4. It is the same as in the docker
image. The previous version is incompatible with some gems used in the
repo.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I have read the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Metrics like emit_count, num_errors, and others are missing when 2.0.1
is used [1][2].

Also, bump .ruby-version to 2.7.4. It is the same as in the docker
image. The previous version is incompatible with some gems used in the
repo.

1. fluent/fluent-plugin-prometheus#195
2. fluent/fluent-plugin-prometheus@0e5d768
@hvaghani221 hvaghani221 merged commit eb17015 into splunk:develop Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants