Skip to content

Conversation

@ahma
Copy link
Contributor

@ahma ahma commented Apr 14, 2022

Proposed changes

net-http-persistent dependency package update.
Based on the following issues

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)

Checklist

@ahma ahma marked this pull request as ready for review April 14, 2022 11:18
Copy link

@g-traveller g-traveller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hvaghani221
Copy link
Contributor

hvaghani221 commented Apr 18, 2022

LGTM!

I just want to confirm the reason for the suggested changes.
splunk_hec plugin depends on net-http-persistent 3.1.0 and elasticsearch plugin depends on net-http-persistent 4.1.0. So both cannot be used simultaneously.

Are there any breaking changes from net-http-persistent from 3.1 to 4.1 that we need to be aware of?

@hvaghani221 hvaghani221 merged commit c343bec into splunk:develop Apr 19, 2022
@ahma
Copy link
Contributor Author

ahma commented Apr 27, 2022

@g-traveller , @harshit-splunk could you release this fix in the near future, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants