Skip to content

Conversation

@toscott
Copy link
Contributor

@toscott toscott commented Jul 28, 2022

Proposed changes

Hoping gzip compression here will help reduce our internet bandwidth consumption leveraging splunk hec to push events to splunk cloud.

Fixes #14

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I have read the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@toscott
Copy link
Contributor Author

toscott commented Jul 28, 2022

New configuration param: gzip_compression true
Defaults false to maintain existing behavior.

@toscott
Copy link
Contributor Author

toscott commented Jul 28, 2022

Network transfer from splunk connect pods dropped around a factor of 10 after enabling this on our cluster.

@toscott
Copy link
Contributor Author

toscott commented Jul 28, 2022

Having some issues after a rebuild, making a couple tweaks and will push another commit.

@toscott
Copy link
Contributor Author

toscott commented Jul 29, 2022

Network transmit rate drop from log forwarders during rollout of compression.
Screen Shot 2022-07-28 at 11 24 52 PM

@hvaghani221
Copy link
Contributor

It looks good. Just wanted to know what was the impact on CPU and memory usage.

@toscott
Copy link
Contributor Author

toscott commented Jul 29, 2022

Baseline memory and cpu looks the same so far. I don't have detailed stats on these pods but my guess is the gc activity is slightly elevated.
Screen Shot 2022-07-29 at 9 29 17 AM

Screen Shot 2022-07-29 at 9 29 38 AM

Copy link
Contributor

@hvaghani221 hvaghani221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hvaghani221 hvaghani221 requested a review from artemrys August 1, 2022 06:00
@hvaghani221 hvaghani221 merged commit 3938a98 into splunk:develop Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support gzip compression on POST

3 participants