Nodeunit to Mocha Transition for Server Side Tests #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeJS 'assert' has been replace with chai 'assert'
fantavlik
reviewed
Jul 16, 2021
| @@ -12,39 +12,38 @@ | |||
| // License for the specific language governing permissions and limitations | |||
| // under the License. | |||
|
|
|||
| (function() { | |||
| var utils = require('../lib/utils'); | |||
| var Async = require('../lib/async'); | |||
There was a problem hiding this comment.
These whitespace changes look good to me, should we add .editorconfig, .prettierrc, and .prettierignore to make sure these are consistent when others are developing in this repo as a followup task?
|
This is looking great, thanks so much for all the effort here @vmalaviya-splunk! Minor comment about following up with prettier and editorconfig rules for the repo in the future if you think that makes sense. |
fantavlik
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the server side nodeunit tests are migrated to mocha tests.
Functionality added to run an individual test file residing in a nested folder.
Functionality added to run individual test case or a test case containing a particular string.