-
Notifications
You must be signed in to change notification settings - Fork 93
Update cli.js #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cli.js #149
Conversation
ashah-splunk
commented
Apr 13, 2022
- changes corresponding to API changes in the dependency library browserify. Resolved compilation error
I'm running into this issue with node 14.19.1: $ rm client/splunk.*
$ node sdkdo compile
Compiled client/splunk.ui.js
Compiled client/splunk.ui.min.js
Compiled client/splunk.ui.timeline.js
Compiled client/splunk.ui.timeline.min.js
Compiled client/splunk.ui.charting.min.js
Compiled client/splunk.ui.charting.js
./splunk-sdk-javascript/bin/cli.js:477
src.toString(),
^
TypeError: Cannot read property 'toString' of undefined
at Readable.<anonymous> (./splunk-sdk-javascript/bin/cli.js:477:33)
at Readable.emit (events.js:400:28)
at Labeled.<anonymous> (./splunk-sdk-javascript/node_modules/read-only-stream/index.js:28:44)
at Labeled.emit (events.js:400:28)
at Labeled.<anonymous> (./splunk-sdk-javascript/node_modules/stream-splicer/index.js:130:18)
at Labeled.emit (events.js:400:28)
at Deps.<anonymous> (./splunk-sdk-javascript/node_modules/stream-splicer/index.js:130:18)
at Deps.emit (events.js:400:28)
at ./splunk-sdk-javascript/node_modules/module-deps/index.js:379:30
at onresolve (./splunk-sdk-javascript/node_modules/module-deps/index.js:181:25)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I was able to get this working after running npm install
- can we update the node_modules
changes associated with this before merging so that others don't run into the same issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it looks like the dependency updates may have caused CI issues with testing