Skip to content

text_type in load_wbb_pbp has MadeFreeThrow for both made and missed free throws #18

@sambruchhaus

Description

@sambruchhaus

Describe the bug
The column text_type in the resulting data from load_wbb_pbp() has "MadeFreeThrow" for both made and missed free throws

To Reproduce
Steps to reproduce the behavior:

  1. Call load_wbb_pbp()
  2. Filter by text to retrieve missed free throws
  3. text for "[Name] missed Free Throw" has "MadeFreeThrow" for the value of text_type

Expected behavior
The text should be either "FreeThrow" or "MissedFreeThrow" for more intuitive filtering.

Screenshots
If applicable, add screenshots to help explain your problem.

Screen Shot 2022-01-11 at 6 34 16 PM

Version:
1.2.1

Additional context
Encountered while trying to calculate Athletes Unlimited Scoring from Play-by-Play

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions