add flogger backend dependency

[benkonz]

I was getting a

No logging platforms found in while using google flogger logging ClassNotFoundException: com.google.common.flogger.backend.system.DefaultPlatform

error when running the tests locally in ratatool. It looks like we need to add a logging backend to ratatool in order to have flogger function properly. According to the flogger docs, https://github.com/google/flogger#1-add-the-dependencies-on-flogger, we need to add https://mvnrepository.com/artifact/com.google.flogger/flogger-system-backend/0.7.4 to build.sbt.

I set the scope to test in order to avoid adding dependencies for our users binary.

[codecov]

Codecov Report

Merging #517 (c265521) into master (67dacd2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   69.63%   69.63%           
=======================================
  Files          36       36           
  Lines        1541     1541           
  Branches      133      133           
=======================================
  Hits         1073     1073           
  Misses        468      468           

Flag	Coverage Δ
ratatoolCli	2.99% <ø> (ø)
ratatoolCommon	∅ <ø> (∅)
ratatoolDiffy	31.79% <ø> (ø)
ratatoolExamples	17.74% <ø> (ø)
ratatoolSampling	59.93% <ø> (ø)
ratatoolScalacheck	81.53% <ø> (ø)
ratatoolShapeless	5.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67dacd2...c265521. Read the comment docs.

[idreeskhan]

fine to merge this to unblock for now but the fact that I don't understand what is going on worries me

[idreeskhan]

If the issues occurs in ParquetIOTest can we move this dep to ratatool-extras

[benkonz]

The docs for flogger say that "the dependency on flogger-system-backend is only required to be included when the binary is run", so I think there is a transitive dependency that is using flogger, but is excluding flogger-backend. Since we aren't supplying a logging backend, flogger is defaulting to throwing an exception.

The strange thing is that you weren't able to replicate it and the tests pass on CI.

[idreeskhan]

Yea that's what I'm referring to. My gut says there's a better way to fix this than adding this dep

[benkonz]

Yea that's what I'm referring to. My gut says there's a better way to fix this than adding this dep

It looks like these tests call ParquetIO.writeToFile, which calls this, which calls this, which has private static final GoogleLogger logger = GoogleLogger.forEnclosingClass();, I'm not sure of an alternative other than deleting the test files