PowerHandler with Prometheus #5
Conversation
lambda_powertools/prometheus.py
Outdated
|
|
||
| modulename = 'prometheus_client' | ||
| if modulename in sys.modules: | ||
| raise Exception("prometheus_client already imported, lambda_powertools.prometheus must be imported before") |
There was a problem hiding this comment.
If possible, describe why you need this. So that I understand what you've been hitting and see if it can be handled differently in a future iteration.
btw, if it's only related to the environment variable that I see below, the module can be reloaded
There was a problem hiding this comment.
Because the global REGISTRY is instantiated at the first prometheus_client import, and the PROMETHEUS_DISABLE_CREATED_SERIES should be set before the first import. The problem is described here (prometheus/client_python#933) and I see now that they just released a configuration for that (https://github.com/prometheus/client_python/releases/tag/v0.18.0). So maybe I can remove that shit 😅
This reverts commit 08740f7.
lambda_powertools/prometheus.py
Outdated
|
|
||
| modulename = 'prometheus_client' | ||
| if modulename in sys.modules: | ||
| raise Exception("prometheus_client already imported, lambda_powertools.prometheus must be imported before") |
There was a problem hiding this comment.
If possible, describe why you need this. So that I understand what you've been hitting and see if it can be handled differently in a future iteration.
btw, if it's only related to the environment variable that I see below, the module can be reloaded
lambda_powertools/prometheus.py
Outdated
|
|
||
|
|
||
| def reset(): | ||
| for collector in list(prometheus_client.REGISTRY._collector_to_names.keys()): |
There was a problem hiding this comment.
You don't need to create a list to iterate over the keys. You could simply use:
for collector in prometheus_client.REGISTRY._collector_to_names.keys():
Or simply do:
for collector in prometheus_client.REGISTRY._collector_to_names:
lambda_powertools/prometheus.py
Outdated
|
|
||
| def filter_metrics(m): | ||
| # Other metric types are not supported so far | ||
| if not m._type == "counter" and not m._type == "histogram": |
There was a problem hiding this comment.
Why not:
if m._type != "counter" and m._type != "histogram":
or:
if m._type not in ("counter", "histogram"):
lambda_powertools/prometheus.py
Outdated
| def get_metrics(): | ||
| new_registry = CollectorRegistry(auto_describe=True) | ||
|
|
||
| for collector in list(filter(filter_metrics, prometheus_client.REGISTRY._collector_to_names.keys())): |
There was a problem hiding this comment.
Same comment I left in the reset function
Automatic support for Prometheus metrics via PROMLOGs in the power_handler.
Based on what done here https://github.com/spreaker/lambda-observability/pull/63 and here https://github.com/spreaker/node-lambda-powertools/blob/master/src/prometheus.js
Related thread on Slack