Skip to content
This repository was archived by the owner on Apr 5, 2022. It is now read-only.

Update Boot plugin to latest snapshot #971

Closed
wants to merge 2 commits into from
Closed

Update Boot plugin to latest snapshot #971

wants to merge 2 commits into from

Conversation

dsyer
Copy link
Contributor

@dsyer dsyer commented Jun 23, 2014

The latest Boot plugin has a number of useful features including the ability to create the executable dirt jar in place (instead of using the spring-xd-exec pseudo-project).

TODO: there's no reason spring-xd-dirt.jar (the non-executable version) needs to have application.yml in it, but the shell tests don't have an application.yml of their own so they will fail if we take it out of the DIRT jar now.

This enables us to add a classifier to the bootRepackage task and
have spring-xd-dirt spit out its own executable jar. Also validates
that 1.1.2 is going to work in other ways.
@dsyer
Copy link
Contributor Author

dsyer commented Jun 23, 2014

Sorry, I didn't know whether you were using spaces or tabs so I chose spaces and it seems like it was neither. Is it better now?

@ilayaperumalg
Copy link
Contributor

The exec jar from spring-xd-exec pseudo project has few more things than what is spring-xd-dirt exec is configured in this PR.

springBoot {
                mainClass = 'org.springframework.xd.dirt.server.SingleNodeApplication'
                layout = 'ZIP'
        }
        jar {
                exclude 'build'
                exclude 'target'
                // FIXME: unhack this
                exclude '**/gemfire-*.jar'
                exclude '**/aspectweaver-*.jar'
                into('.') { from '../spring-xd-dirt/src/main/resources/log4j.properties' }
                into('modules') { from '../modules' }
                into('config') { from '../config' }
                into('spring-xd-ui/dist') { from '../spring-xd-ui/dist' }
        }
        moduleProjects.each { moduleProject ->
                project.jar.dependsOn moduleProject.copyLibs
        }

@ericbottard
Copy link
Contributor

Do we really want to maintain the -exec pseudo project while at the same time doing XD-1463?

@markpollack
Copy link
Contributor

the -exec pseudo project doesn't end up in the bits we ship (unlike commands or config snippits) so it seems benign to keep it around as it may help 'reboot' experiments with CF, but if the boot upgrade provides the same functionality, we should remove the duplication.

@markpollack
Copy link
Contributor

Ah, I see from Ilaya's comment it does more...so then let's keep it around. LGTM, can merge.

@ilayaperumalg
Copy link
Contributor

Merged 5241fec

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants