Open
Conversation
Signed-off-by: Mikhail Polivakha <[email protected]>
Member
|
I don't understand why this class was moved, can you explain? |
Contributor
Author
|
Hey @spencergibb ! Because there were a TODO for this, 5hat is it :) You can verify it by reviwing the diff. I did not pursue any sophisticated objective here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated
ConfigDataMissingEnvironmentPostProcessorto a necessary directory in a backward-compatible way.The deprecation notice, I guess, should be since Spring Cloud 5 major version to give a greater grace period for migration, but anyway, it is up to core team. The core team might also consider removing the old
ConfigDataMissingEnvironmentPostProcessoron the new major.Also introduced polishing of the existing
ConfigDataMissingEnvironmentPostProcessor.