Retry filter based on Spring Framework's retry functionality #3970
+721
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjbaxter
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new FrameworkRetry filter based on Spring Framework's retry functionality as an alternative to the existing Retry filter (which depends on Spring Retry). The existing Retry filter is deprecated since Spring Retry has been placed in maintenance-only mode.
Key changes:
- Added
FrameworkRetryFilterFunctionswith retry logic using Spring Framework'sRetryTemplateand customRetryPolicy - Deprecated
RetryFilterFunctionsand refactored it to reuseRetryConfigandRetryExceptionfrom the new framework retry implementation - Added comprehensive test coverage for the new retry filter including body caching scenarios
- Updated documentation to warn users about the deprecated filter and recommend the new framework-based filter
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| FrameworkRetryFilterFunctions.java | New retry filter implementation using Spring Framework retry support with custom composite retry policy |
| RetryFilterFunctions.java | Deprecated existing retry filter and refactored to reuse RetryConfig and RetryException from FrameworkRetryFilterFunctions |
| FrameworkRetryFilterFunctionTests.java | Added unit tests for framework retry filter covering GET and POST with body caching |
| HttpClientApplication.java | Added integration test route and controller endpoint for framework retry |
| HttpClientApplicationTests.java | Added integration test verifying framework retry behavior |
| framework-retry.adoc | New documentation page for framework retry filter with examples and warnings |
| retry.adoc | Added deprecation warning directing users to the new framework retry filter |
| nav.adoc | Added navigation link to framework retry filter documentation |
| NettyRoutingFilterIntegrationTests.java | Code formatting improvement (multi-line method chain) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/modules/ROOT/pages/spring-cloud-gateway-server-webmvc/filters/framework-retry.adoc
Show resolved
Hide resolved
.../src/main/java/org/springframework/cloud/gateway/tests/httpclient/HttpClientApplication.java
Show resolved
Hide resolved
.../java/org/springframework/cloud/gateway/server/mvc/filter/FrameworkRetryFilterFunctions.java
Outdated
Show resolved
Hide resolved
ryanjbaxter
force-pushed
the
framework-retry
branch
from
3fee569 to
e2de699
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/modules/ROOT/pages/spring-cloud-gateway-server-webmvc/filters/framework-retry.adoc
Outdated
Show resolved
Hide resolved
ryanjbaxter
force-pushed
the
framework-retry
branch
from
e2de699 to
6c61830
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…retry functionality
ryanjbaxter
force-pushed
the
framework-retry
branch
from
6c61830 to
c4eb766
Compare
ryanjbaxter
force-pushed
the
framework-retry
branch
from
9aacd4f to
0c71800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.