Upgrade To Fabric8 7.3.x

[ryanjbaxter]

Then undo this commit
4d56210

[wleese]

Today Spring Cloud 2025.0.0 will be released, I'm assuming this change won't make it? If so, then do you know when can we expect 2025.1.0? That said, what will be done for Spring Boot 3.5.0? That's my main concern :)

[ryanjbaxter]

Unfortunately we cannot make major upgrades to dependencies in a minor release of Spring Cloud (which 2025.0.x is). We won't be able to upgrade to 7.3.x until we release 2025.1.0 later this year. 2025.1.0 will be compatible with Spring Boot 4.0.0.

[wleese]

@ryanjbaxter with Spring Boot 3.5.0 upgrading Jackson to 2.19 and Spring Cloud 2025.0.x being incompatible due to fabric8io/kubernetes-client#7036, then I guess someone needs to ask fabric8io for a 6.x release with a fix? Or Spring Boot will have to downgrade Jackson from 2.19 to 2.18.x?

Otherwise Spring Boot 3.5.0 will not be compatible with any version of Spring Cloud unless I'm mistaken?

[ryanjbaxter]

Well Spring Boot 3.5.0 already went out with Jackson 2.19 so we can't change that.

4d56210 forces Spring Cloud Kubernetes Fabric8 jars to use Jackson 2.18.x. Also as far as I can tell the requirement for Jackson 2.18.x from Fabric8 is only for testing 4d56210#diff-06eabae3025b0a49ae71008cf04bf3ce1d68369fb000521718d7f420c9cc5eb4.

I have not found that the version of Jackson effects anything at runtime.

[wleese]

I have not found that the version of Jackson effects anything at runtime.

We have an internal framework based on Spring Boot and Spring Cloud and our integration tests started failing.

Caused by: com.fasterxml.jackson.databind.JsonMappingException: Cannot invoke "com.fasterxml.jackson.databind.JsonSerializer.serialize(Object, com.fasterxml.jackson.core.JsonGenerator, com.fasterxml.jackson.databind.SerializerProvider)" because "keySerializer" is null (through reference chain: io.fabric8.kubernetes.api.model.GenericKubernetesResource["getAdditionalProperties"]->java.util.LinkedHashMap["data"])
	at com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:400)
	at com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:359)
	at com.fasterxml.jackson.databind.ser.std.StdSerializer.wrapAndThrow(StdSerializer.java:324)
	at com.fasterxml.jackson.databind.ser.std.MapSerializer.serializeFields(MapSerializer.java:810)
	at com.fasterxml.jackson.databind.ser.std.MapSerializer.serializeWithoutTypeInfo(MapSerializer.java:763)
	at com.fasterxml.jackson.databind.ser.AnyGetterWriter.getAndSerialize(AnyGetterWriter.java:81)
	at com.fasterxml.jackson.databind.ser.AnyGetterWriter.serializeAsField(AnyGetterWriter.java:89)
	at io.fabric8.kubernetes.model.jackson.BeanPropertyWriterDelegate.serializeAsField(BeanPropertyWriterDelegate.java:68)

See io.fabric8.kubernetes.model.jackson.BeanPropertyWriterDelegate.serializeAsField(BeanPropertyWriterDelegate.java:68)

Independently, someone else beat us to creating an issue:
fabric8io/kubernetes-client#7036

So while indeed your diff only shows some test-scoped dependencies, there is bad stuff happening at runtime (in our specific case emulated by failing integration tests that use Spring Cloud Kubernetes).

[ryanjbaxter]

Can you provide a sample which reproduces the issue you are seeing?

[wleese]

Can't do right now. I did just create an issue for Fabric8 asking for a 6.x fix on Springs behalf. Perhaps I moved too fast on this. I might have time Friday to make a sample.

[ryanjbaxter]

We have made the call to upgrade Fabric8 since this is probably the best way to deal with the issue.

[manusa]

We have made the call to upgrade Fabric8 since this is probably the best way to deal with the issue.

Most of the 7.x breaking changes probably won't affect you.
In any case, if this doesn't fly, let us know so we proceed and try to release the backport.

[ryanjbaxter]

Thanks. We didn't have any api related changes to make which was good. Our major concern are the consumers of spring cloud k8s, it's impossible to predict what the impact is on them. Unfortunately our hand is forced in this case by the Jackson dependency upgrade in spring boot.