Fix fabric8 client dependency (related to issue 900) #905
Conversation
|
This PR should go after this one and then changes will make a lot more sense. I did not want to muddy the waters in that PR, that fixes an actual problem... When that one is merged, I'll comment on this one more if needed. But basically the idea is the same as there, we track |
wind57
changed the title
| </exclusions> | ||
| </dependency> | ||
|
|
||
| <dependency> |
There was a problem hiding this comment.
this is the actual change in this PR, we should drop kubernetes-client explicit dependency, it is managed by bom anyway
|
Seems like some of these changes duplicate whats in #904 |
|
right, I branched from that one - because otherwise the build would have failed. That is why I said that if we agree on that one and merge it, and then look at this one, it will make more sense (the overlapping changes would not be present) |
| @@ -245,24 +245,6 @@ | |||
| <scope>test</scope> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
I think that now it makes a lot more sense - just like the mock server removal, we remove client also. It has the same <scope>test</scope>
| @@ -84,6 +84,13 @@ | |||
| <dependency> | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-starter-test</artifactId> | |||
| <!-- in favor of mockito-inline --> | |||
There was a problem hiding this comment.
some tests were failing, so need mockito-inline.
|
@ryanjbaxter it should make a lot more sense now |
No description provided.