Authorize with anonymous principal if principal name is null #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agileknight Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@agileknight Thank you for signing the Contributor License Agreement! |
OlgaMaciaszek
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Hi @agileknight. Thanks for submitting the PR. In general, looks good. Please add your name with @author tag to the javadocs of all the files you've modified. Please update the date in the license comment in the files you've modified to 2015-2024.
Also, please submit this PR against 4.1.x instead, so that it also gets included in the 2023.0.x release train.
OlgaMaciaszek
requested changes
Sep 4, 2024
agileknight
force-pushed
the
authorize-with-anonymous-when-principal-name-is-null
branch
2 times, most recently
from
751040d to
8304aec
Compare
The authorizedClientManager.authorize method requires a non-null principal name or it will usually throw an exception in practice like "principalName cannot be empty". Using the anonymous principal in this case like for a null principal handles the situation more gracefully. Fixes spring-cloud#1049
agileknight
force-pushed
the
authorize-with-anonymous-when-principal-name-is-null
branch
from
8304aec to
ab8d462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authorizedClientManager.authorize method requires a non-null principal name or it will usually throw an exception in practice like "principalName cannot be empty".
Using the anonymous principal in this case like for a null principal handles the situation more gracefully.
Fixes #1049