Skip to content

Use case-insensitive ResponseEntity headers. Fixes gh-456. #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2021
Merged

Use case-insensitive ResponseEntity headers. Fixes gh-456. #472

merged 1 commit into from
Jan 27, 2021

Conversation

OlgaMaciaszek
Copy link
Collaborator

No description provided.

@OlgaMaciaszek OlgaMaciaszek added the bug Something isn't working label Jan 27, 2021
@OlgaMaciaszek OlgaMaciaszek added this to the 2.2.7.RELEASE milestone Jan 27, 2021
@OlgaMaciaszek OlgaMaciaszek self-assigned this Jan 27, 2021
spencergibb
spencergibb approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the tests fail without the fix

@codecov
Copy link

codecov bot commented Jan 27, 2021 •
edited
Loading

Codecov Report

Merging #472 (0c7cc72) into 2.2.x (6b29a1f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              2.2.x     #472   +/-   ##
=========================================
  Coverage     77.52%   77.52%           
  Complexity      480      480           
=========================================
  Files            64       64           
  Lines          1913     1913           
  Branches        273      273           
=========================================
  Hits           1483     1483           
  Misses          304      304           
  Partials        126      126
Impacted Files Coverage Δ Complexity Δ
...mework/cloud/openfeign/FeignAutoConfiguration.java 84.37% <ø> (ø) 6.00 <0.00> (ø)
...cloud/openfeign/support/ResponseEntityDecoder.java 91.30% <100.00%> (ø) 9.00 <2.00> (ø)

@OlgaMaciaszek OlgaMaciaszek merged commit c672d20 into 2.2.x Jan 27, 2021
@OlgaMaciaszek OlgaMaciaszek deleted the case-insensitive-response-entity-headers branch November 30, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencergibb spencergibb spencergibb approved these changes

Assignees

@OlgaMaciaszek OlgaMaciaszek

Labels
bug Something isn't working
Projects
None yet
Milestone
2.2.7.RELEASE
Development

Successfully merging this pull request may close these issues.
2 participants
@OlgaMaciaszek @spencergibb