-
Notifications
You must be signed in to change notification settings - Fork 799
GH-475: Optional Feign clients eager initialization mechanism #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
============================================
+ Coverage 77.85% 78.01% +0.16%
- Complexity 489 496 +7
============================================
Files 60 62 +2
Lines 1820 1838 +18
Branches 267 267
============================================
+ Hits 1417 1434 +17
- Misses 256 257 +1
Partials 147 147
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignAutoConfiguration.java
Show resolved
Hide resolved
...enfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignEagerLoadProperties.java
Outdated
Show resolved
Hide resolved
...oud-openfeign-core/src/main/resources/META-INF/additional-spring-configuration-metadata.json
Outdated
Show resolved
Hide resolved
...e/src/test/java/org/springframework/cloud/openfeign/FeignClientEagerInitializationTests.java
Outdated
Show resolved
Hide resolved
@OlgaMaciaszek , author of original issue was struggling with initialising feign clients in async way from ForkJoinPool, and you proposed an alternative - implement something similar to ribbon.eager-load mechanism. I think my PR won't fix sample from original issue, but propose options to provide such functionality directly without need for such workarounds with supplying fake request to FJP or any other thread pool. |
@OlgaMaciaszek, hi. Can you update me with current status of review? |
@Periecle , I understood you were still working on this bit for the PR:
Or will you be submitting it in another PR? |
Pull Request majorly influenced by similar Ribbon feature, therefore API and configuration are close to each other for usability.
Also updated documentation explaining configuration and implementation details.
Fixes #475