Provide an alternate naming convention for CB ids #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencergibb
approved these changes
Mar 9, 2022
ryanjbaxter
force-pushed
the
provide-alternate-cbname
branch
2 times, most recently
from
271af4f to
4ad6bb0
Compare
spencergibb
reviewed
Mar 9, 2022
| @@ -166,10 +166,20 @@ public Targeter defaultFeignTargeter() { | |||
|
|
|||
| @Bean | |||
| @ConditionalOnMissingBean(CircuitBreakerNameResolver.class) | |||
| @ConditionalOnProperty(value = "feign.circuitbreaker.alphanumericNames.enabled", | |||
There was a problem hiding this comment.
We need to use - rather than camel case in auto configuration, so alphanumeric-names. Users can use relaxed binding
…uration via configuration properties Configuration properties cannot contain characters like hash, parens, or commas
ryanjbaxter
force-pushed
the
provide-alternate-cbname
branch
from
4ad6bb0 to
b90559a
Compare
spencergibb
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration properties cannot contain characters like hash, parens, or commas.
See spring-cloud/spring-cloud-circuitbreaker#141