Skip to content

Spring Session support broken post Spring Boot 2.0.0 M2 #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vpavic opened this issue Jun 27, 2017 · 4 comments
Closed

Spring Session support broken post Spring Boot 2.0.0 M2 #455

vpavic opened this issue Jun 27, 2017 · 4 comments
Assignees

Comments

@vpavic
Copy link
Contributor

vpavic commented Jun 27, 2017

Due to recent changes in Spring Session which have been picked up by Boot in spring-projects/spring-boot@f26f817, Initializr generated projects that include Session will refer to non-existing org.springframework.session:spring-session artifact.

@snicoll
Copy link
Contributor

snicoll commented Jun 27, 2017

Thanks for the heads up. I'll disable spring session for now and would like some guidance as how to restore it.

IMO (and that's not the right place to discuss this) the recent changes of one jar per store is a step backwards with regards to usability. We won't add one entry per store here so where does that leave us?

@snicoll
Copy link
Contributor

snicoll commented Jul 16, 2017

There are things that should happen in Spring Boot to improve the developer experience with Spring Session the way it has been modularized. Regardless, we need to restore spring session ASAP on the production instance. I've made a proposal in the Spring Boot related issue (spring-projects/spring-boot#9552 (comment))

Any feedback on the proposal would be welcome so that we can move forward with this.

@snicoll snicoll changed the title Spring Session support broken with Boot 2.0.0 (SNAPSHOT) Spring Session support broken post Spring Boot 2.0.0 M2 Jul 23, 2017
@snicoll
Copy link
Contributor

snicoll commented Aug 23, 2017

We are close to 2 months with this with zero feedback.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Sep 6, 2017
@vpavic
Copy link
Contributor Author

vpavic commented Sep 7, 2017

Having in mind the current constraints in Boot/Initializr the proposal does seem as the best way to address the current.

Obviously it isn't ideal that when user selects session, jdbc and redis they get both spring-session-data-redis and spring-session-jdbc but I assume there are plenty other situations where generated project requires user intervention. Other situation is when user selects session but no data store starter that results in spring-session-core which by itself does not contain a production grade SessionRepository implementation.

@snicoll snicoll removed the status: waiting-for-feedback We need additional information before we can continue label Sep 15, 2017
@snicoll snicoll self-assigned this Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants