Cannot POST to /api/visits

[peterfk]

This issue is very similar to #139 in that the POST payload is just

{ "date": "2013-01-01", "description": "rabies shot" }

It's missing the foreign key to Pets table so you get this error

{ "type": "http://localhost:9966/petclinic/api/visits", "title": "DataIntegrityViolationException", "status": 404, "detail": "could not execute statement [NULL not allowed for column \"PET_ID\"; SQL statement:\ninsert into visits (visit_date,description,pet_id,id) values (?,?,?,default) [23502-232]] [insert into visits (visit_date,description,pet_id,id) values (?,?,?,default)]; SQL [insert into visits (visit_date,description,pet_id,id) values (?,?,?,default)]; constraint [null]", "instance": "/petclinic/api/visits", "timestamp": "2025-05-22T20:34:23.793194Z" }

There is also a separate POST method

/api/owners/{ownerId}/pets/{petId}/visits

which requires the petId in the URL and does work so presumably that's what everyone is using. Not sure why it's part of api/owners though? And I don't think you would really need to pass the ownerId to insert into the visit table.

Not sure what the best approach is but it may be possible to list petId as an optional field in the /api/visit method, similar to the date field.

[dineshkumarssundaram]

Hi @peterfk, I’d like to work on this issue.

My proposed solution:

• Update the /api/visits POST endpoint to accept a petId in the request body.
• In the controller, fetch the corresponding Pet entity and set it when saving the Visit.
• This will fix the DataIntegrityViolationException caused by missing foreign key.
• I’ll also add/update integration tests for this endpoint.

Could you please assign this issue to me so I can start working on it?

[peterfk]

HI @dineshkumarssundaram thank you for your interest in this issue but I have already created a pull request for it #234. If you like you can test it and comment. Also I am not an admin for this repo. thx!

[dineshkumarssundaram]

Oh Thank you