Implement KotlinModule for JSON schema generation #1766
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a great contribution, Sebastian is on PTO this week, so he can review next week when he is back. Thanks! |
|
@sdeleuze can you take a look as time permits please |
sdeleuze
requested changes
Dec 23, 2024
There was a problem hiding this comment.
Looks good, thanks for this contribution, please just remove the Kotlin version bump to 2.0.21 as we need to keep a Kotlin 1.9 baseline with Boot 3.x. I will update the documentation accordingly once merged.
sdeleuze
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
@markpollack @tzolov Looks good to merge if tests are green.
|
Thank you @devcrocod for the contribution and @sdeleuze for reviewing it! |
|
rebased , squashed and merged at 756a9dc |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1667
Implemented
com.github.victools.jsonschema.generator.Modulefor Kotlin. This adds support for generating JSON schemas from Kotlin classes by leveraging Kotlin reflection. The module handles nullability, default values, and required properties based on Kotlin's typesAdded
kotlin-reflectdependencyUpdated Kotlin version to 2.0.21